From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29482 invoked by alias); 26 Mar 2013 11:16:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29376 invoked by uid 89); 26 Mar 2013 11:16:04 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 11:16:01 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QBFxOW023730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Mar 2013 07:15:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2QBFwXW010758; Tue, 26 Mar 2013 07:15:58 -0400 Message-ID: <5151836D.90401@redhat.com> Date: Tue, 26 Mar 2013 16:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Metzger, Markus T" CC: GDB Patches Subject: Re: "set record instruction-history" ? References: <51507403.6030208@redhat.com> <51508D60.6040906@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg00965.txt.bz2 On 03/26/2013 07:46 AM, Metzger, Markus T wrote: > Shouldn't we map 0 to INT_MAX before committing the new value? That's already done for us before this function is reached, by the set/show machinery. "commit" here refers to copying the set/show command's control variable value to the real setting variable (record_(call|insn)_history_size). > The functionality should be covered by the gdb.btrace test suite. Do you want > to commit your patch or do you want me to test and then commit it? Could you test and report back please? I believe my laptop's cpu is one of those where branch tracing is borked and ended up disabled. ... (gdb) record btrace Target does not support branch tracing. (gdb) testcase ../../../src/gdb/testsuite/gdb.btrace/enable.exp completed in 1 seconds Running ../../../src/gdb/testsuite/gdb.btrace/function_call_history.exp ... testcase ../../../src/gdb/testsuite/gdb.btrace/function_call_history.exp completed in 0 seconds Running ../../../src/gdb/testsuite/gdb.btrace/instruction_history.exp ... testcase ../../../src/gdb/testsuite/gdb.btrace/instruction_history.exp completed in 0 seconds === gdb Summary === Thanks, -- Pedro Alves