From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14153 invoked by alias); 25 Mar 2013 10:50:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14127 invoked by uid 89); 25 Mar 2013 10:50:37 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 10:50:35 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UK4z3-0004zv-7h from Yao_Qi@mentor.com ; Mon, 25 Mar 2013 03:50:33 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Mar 2013 03:50:33 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 25 Mar 2013 03:50:32 -0700 Message-ID: <51502BA8.3060306@codesourcery.com> Date: Mon, 25 Mar 2013 14:40:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii CC: , , , Subject: Re: [MinGW-w64]Build gdb/ctf.c failed References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-4-git-send-email-yao@codesourcery.com> <51492077.30307@codesourcery.com> <83sj3qyogk.fsf@gnu.org> <87vc8m7z1d.fsf@fleche.redhat.com> <514FA117.9030604@gmail.com> <83hajz3oef.fsf@gnu.org> <515009B1.5030500@codesourcery.com> <838v5b3mcx.fsf@gnu.org> In-Reply-To: <838v5b3mcx.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-SW-Source: 2013-03/txt/msg00928.txt.bz2 On 03/25/2013 04:38 PM, Eli Zaretskii wrote: > I think you should "#undef mkdir" before redefining it, to be > absolutely safe here. Added. > > Other than that, I'm OK with this. Check in the patch below. -- Yao (齐尧) gdb: 2013-03-25 Yao Qi * ctf.c [USE_WIN32API]: Undef 'mkdir' and use 'mkdir' instead of '_mkdir'. --- gdb/ctf.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gdb/ctf.c b/gdb/ctf.c index d160f63..6b68239 100644 --- a/gdb/ctf.c +++ b/gdb/ctf.c @@ -296,7 +296,8 @@ ctf_target_save (struct trace_file_writer *self, } #ifdef USE_WIN32API -#define mkdir(pathname, mode) _mkdir (pathname) +#undef mkdir +#define mkdir(pathname, mode) mkdir (pathname) #endif /* This is the implementation of trace_file_write_ops method -- 1.7.7.6