From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1037 invoked by alias); 25 Mar 2013 08:25:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1008 invoked by uid 89); 25 Mar 2013 08:25:44 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 08:25:42 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UK2ip-0001oZ-KG from Yao_Qi@mentor.com ; Mon, 25 Mar 2013 01:25:39 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Mar 2013 01:25:39 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Mon, 25 Mar 2013 01:25:38 -0700 Message-ID: <515009B1.5030500@codesourcery.com> Date: Mon, 25 Mar 2013 09:42:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Kai Tietz CC: Eli Zaretskii , asmwarrior , , Subject: Re: [MinGW-w64]Build gdb/ctf.c failed References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-4-git-send-email-yao@codesourcery.com> <51492077.30307@codesourcery.com> <83sj3qyogk.fsf@gnu.org> <87vc8m7z1d.fsf@fleche.redhat.com> <514FA117.9030604@gmail.com> <83hajz3oef.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-SW-Source: 2013-03/txt/msg00918.txt.bz2 On 03/25/2013 04:06 PM, Kai Tietz wrote: > The function 'mkdir' (please note it is without leading underscore), > is declared in io.h header, which is of course include within unistd.h > header. Right, 'mkdir' is declared io.h, which is included in unistd.h. Looks like we should use "mkdir" instead of "_mkdir". How about the patch below? It unbreaks the build of using mingw-w64 toolchain, while mingw32 toolchain doesn't complain about it. -- Yao (齐尧) gdb: 2013-03-25 Yao Qi * ctf.c [USE_WIN32API]: Use 'mkdir' instead of '_mkdir'. --- gdb/ctf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/ctf.c b/gdb/ctf.c index 8510ff9..3df2de5 100644 --- a/gdb/ctf.c +++ b/gdb/ctf.c @@ -296,7 +296,7 @@ ctf_target_save (struct trace_file_writer *self, } #ifdef USE_WIN32API -#define mkdir(pathname, mode) _mkdir (pathname) +#define mkdir(pathname, mode) mkdir (pathname) #endif /* This is the implementation of trace_file_write_ops method -- 1.7.7.6