From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99843-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6770 invoked by alias); 25 Mar 2013 03:30:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 6750 invoked by uid 89); 25 Mar 2013 03:30:42 -0000
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 03:30:40 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1UJy7K-0002o3-6j from Hui_Zhu@mentor.com ; Sun, 24 Mar 2013 20:30:38 -0700
Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Sun, 24 Mar 2013 20:30:37 -0700
Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Sun, 24 Mar 2013 20:30:36 -0700
Message-ID: <514FC4D8.1080207@mentor.com>
Date: Mon, 25 Mar 2013 07:52:00 -0000
From: Hui Zhu <hui_zhu@mentor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>, Stan Shebs	<stan@codesourcery.com>, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Reset tracepoint step_count to 0 before set it action
References: <514EE46A.4070808@mentor.com> <514F0902.4050404@codesourcery.com>
In-Reply-To: <514F0902.4050404@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-03/txt/msg00908.txt.bz2

On 03/24/13 22:09, Yao Qi wrote:
> On 03/24/2013 07:32 PM, Hui Zhu wrote:
>> 2013-03-24  Hui Zhu<hui@codesourcery.com>
>>
>>     * breakpoint.c (do_map_commands_command): Reset step_count to 0
>>     if this is a tracepoint.
>>     * tracepoint.c (trace_actions_command): Ditto.
>
> Looks both do_map_commands_command and trace_actions_command call check_tracepoint_command, so why don't set step_count in check_tracepoint_command?
>

I don't think this is a good place for put this reset code because this function will be call each time when user input a new line for actions.

Thanks,
Hui