From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6423 invoked by alias); 24 Mar 2013 12:02:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6384 invoked by uid 89); 24 Mar 2013 12:02:17 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 24 Mar 2013 12:02:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2OC2Cuo022047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 24 Mar 2013 08:02:12 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2OC2BI6015650 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 24 Mar 2013 08:02:12 -0400 Message-ID: <514EEB43.6040101@redhat.com> Date: Mon, 25 Mar 2013 00:53:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread References: <514E8D6C.2010606@mentor.com> In-Reply-To: <514E8D6C.2010606@mentor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg00897.txt.bz2 On 03/23/2013 10:21 PM, Hui Zhu wrote: > -break-insert -f -c k>0 "pendfunc1 if k == 0" > &"Function \"pendfunc1\" not defined.\n" > ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="",pending="pendfunc1 > if k == 0",cond="k>0",times="0",original-location="pendfunc1 if k == 0"} IMO, this should not be permitted at all. Two reasons: 1) We could argue about which condition is correct to keep. 2) The MI specification does not say anything about permitting this type of usage. [I would therefore argue it is illegal.] Likewise for "thread" (and "task", but there is no task parameter for create_breakpoint for some reason). Ideally an error should be issued when the breakpoint is set: -break-insert -c "argc > 1" "main if argc > 2" ^error,msg="Garbage 'if argc > 2' at end of command" Please remember to submit a test case (or cases) with patches whenever possible. Keith