Re: one week to gdb-7.6 release?

Joel Brobecker
2013-03-23T16:25:50Z

Hi Eli,

> Committed to the trunk as below. This incorporates comments from Jan.
> OK to commit the same to the 7.6 branch?

> 2013-03-18 Eli Zaretskii <eliz@gnu.org>
>
> * windows-nat.c (windows_get_absolute_argv0): New function.
> * windows-nat.h: Add its prototype.
>
> * main.c (get_init_files): Use filename_ncmp instead of strncmp.
> Use IS_DIR_SEPARATOR instead of looking for a character inside
> SLASH_STRING. Include filenames.h.
> (captured_main) [__MINGW32__]: Make argv[0] absolute, so that
> relocate_gdb_directory works when passed gdb_program_name.
> Include windows-nat.h.

I think that the patch, as is, breaks the windows-hosted cross-debugger
builds. windows-nat.o is only linked in when configured as a native
debugger:

if test "${gdb_native}" = "yes"; then
host_makefile_frag=${srcdir}/config/${gdb_host_cpu}/${gdb_host}.mh

I think that the standard approach in this case would be to define
a function in utils.h, and have its implementation in both posix-hdep.c
and mingw-hdep.c.

A minor nitpick on coding style: Can you add an empty line between
the comment documenting a function ands its definition?

Thank you,
--
Joel