From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12719 invoked by alias); 15 Mar 2013 17:50:44 -0000 Received: (qmail 12671 invoked by uid 22791); 15 Mar 2013 17:50:41 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a92.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Mar 2013 17:50:34 +0000 Received: from homiemail-a92.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a92.g.dreamhost.com (Postfix) with ESMTP id 1F2473DC05B; Fri, 15 Mar 2013 10:50:34 -0700 (PDT) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a92.g.dreamhost.com (Postfix) with ESMTPSA id 62A013DC05E; Fri, 15 Mar 2013 10:50:33 -0700 (PDT) Message-ID: <51435F68.3060509@eagerm.com> Date: Fri, 15 Mar 2013 17:55:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Steve Ellcey CC: gdb-patches@sourceware.org Subject: Re: [patch, simulator] Fix sim_command_completer arguments. References: <2642b17f-5e3b-41b2-a985-ffcaa9220e95@BAMAIL02.ba.imgtec.org> In-Reply-To: <2642b17f-5e3b-41b2-a985-ffcaa9220e95@BAMAIL02.ba.imgtec.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00680.txt.bz2 On 03/15/2013 10:31 AM, Steve Ellcey wrote: > My build of gdb and sim have recently started failing with: > > /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c: In function '_initialize_remote_sim': > /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c:1323: error: passing argument 2 of 'set_cmd_completer' from incompatible pointer type > /local/home/sellcey/nightly2/src/gdb/gdb/command.h:161: note: expected 'struct VEC_char_ptr * (*)(struct cmd_list_element *, const char *, const char *)' but argument is of type 'struct VEC_char_ptr * (*)(struct cmd_list_element *, char *, char *)' > > I didn't see any change in gdb/sim that might be causing this but I am > building with the latest (ToT) GCC and I think a change there might have > caused GCC to start catching this discrepency in argument types. I would > like to fix it by adding the 'const' modifier to the sim_command_completer > text and word arguments so that its argument types match filename_completer, > expression_completer, etc. I encountered a similar tightening of type checking with gcc-head while building opcode/mips-dis.c. OK for MicroBlaze. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077