Re: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt)

Tom Tromey
2013-03-15T16:43:28Z

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> Here is the updated one, in which 'WORDS_BIGENDIAN' is checked to get
Yao> the host-endianness. This macro is used somewhere else in GDB, so looks
Yao> it is a right way.

This part is ok.

Yao> /* Create DIRNAME. */
Yao> - if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH)
Yao> - && errno != EEXIST)
Yao> +#ifdef USE_WIN32API
Yao> + ret = mkdir (dirname);
Yao> +#else
Yao> + ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR);
Yao> +#endif

I think S_IRUSR, S_IWUSR,and S_IXUSR are generally ok.
At least, I see them unprotected in remote-fileio.c.
So I think a simpler patch here would suffice, and would be cleaner
besides.

thanks,
Tom