Re: [PATCH 1/3] Import mkdir module

Joel Brobecker
2013-03-19T21:18:15Z

> > 1. Check out my gulib repository to
> > 8d5bd1402003bd0153984b138735adf537d960b0, which is required by
> > update-gnulib.sh, so that we just import mkdir module instead
> > of upgrading gnulib we are using.
> > 2. Modify update-gnulib.sh to add mkdir.
> > 3. bash update-gnulib.sh <my gnulib repository>
> >
> > Build GDB with all-targets enabled and cross compile GDB for mingw32
> > target.
>
> Hi.
> A ton of random stuff got dragged in.
> Is this typical of gnulib?
>
> Including, but not limited to, the following.
>
> If all this extra stuff is just due to updating to a newer version of
> gnulib, please separate out the update from the addition of mkdir.

Looking at the SHA1 and the update procedure, Yao used the correct
version of gnulib, and the extra stuff are dependencies. This is
typical of gnlib, and OK. I see where Eli is coming from when
he proposes implementing it locally rather than dependening on
gnulib, but I do feel like it's better to take advantage of gnulib
for portability issues. So I have a preference for gnulib, but
I will not object to a local implementation instead.

--
Joel