From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1872 invoked by alias); 15 Mar 2013 14:43:48 -0000 Received: (qmail 1861 invoked by uid 22791); 15 Mar 2013 14:43:46 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Mar 2013 14:43:41 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UGVr9-0000QI-Rg from Yao_Qi@mentor.com ; Fri, 15 Mar 2013 07:43:39 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 15 Mar 2013 07:43:38 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Fri, 15 Mar 2013 07:43:37 -0700 Message-ID: <5143335C.2010902@codesourcery.com> Date: Fri, 15 Mar 2013 14:43:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pierre Muller CC: Subject: Re: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt) References: <20130315020212.GA23545@sourceware.org> <5142E409.5090109@codesourcery.com> <002901ce2162$414d7530$c3e85f90$@muller@ics-cnrs.unistra.fr> <51430063.2060007@codesourcery.com> In-Reply-To: <51430063.2060007@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00667.txt.bz2 On 03/15/2013 07:05 PM, Yao Qi wrote: > This problem is addressed by using "native" endianness in CTF metadata, > so BYTE_ORDER and LITTLE_ENDIAN can be avoided. Here is the updated one, in which 'WORDS_BIGENDIAN' is checked to get the host-endianness. This macro is used somewhere else in GDB, so looks it is a right way. Rebuild native GDB on x86-linux and cross build GDB for mingw32 target respectively. -- Yao (齐尧) gdb: 2013-03-15 Yao Qi * ctf.c (ctf_save_metadata_header): Define macro HOST_ENDIANNESS. Write HOST_ENDIANNESS to metadata. (ctf_start) [USE_WIN32API]: Call mkdir with DIRNAME only. [!USE_WIN32API]: Call mkdir with DIRNAME and mode parameter. --- gdb/ctf.c | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/gdb/ctf.c b/gdb/ctf.c index 44c4e9e..09f9fae 100644 --- a/gdb/ctf.c +++ b/gdb/ctf.c @@ -242,9 +242,15 @@ ctf_save_metadata_header (struct trace_write_handler *handler) " } := chars;\n"); ctf_save_write_metadata (handler, "\n"); +#if WORDS_BIGENDIAN +#define HOST_ENDIANNESS "be" +#else +#define HOST_ENDIANNESS "le" +#endif + ctf_save_write_metadata (handler, metadata_fmt, CTF_SAVE_MAJOR, CTF_SAVE_MINOR, - BYTE_ORDER == LITTLE_ENDIAN ? "le" : "be"); + HOST_ENDIANNESS); ctf_save_write_metadata (handler, "\n"); } @@ -298,10 +304,16 @@ ctf_start (struct trace_file_writer *self, const char *dirname) struct ctf_trace_file_writer *writer = (struct ctf_trace_file_writer *) self; int i; + int ret = 0; /* Create DIRNAME. */ - if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH) - && errno != EEXIST) +#ifdef USE_WIN32API + ret = mkdir (dirname); +#else + ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR); +#endif + + if (ret && errno != EEXIST) error (_("Unable to open directory '%s' for saving trace data (%s)"), dirname, safe_strerror (errno)); -- 1.7.7.6