From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8754 invoked by alias); 14 Mar 2013 19:35:26 -0000 Received: (qmail 8658 invoked by uid 22791); 14 Mar 2013 19:35:25 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 19:35:15 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2EJZFaT017869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Mar 2013 15:35:15 -0400 Received: from localhost.localdomain (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2EJZDEL003192; Thu, 14 Mar 2013 15:35:14 -0400 Message-ID: <51422671.7080603@redhat.com> Date: Thu, 14 Mar 2013 19:35:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes. References: <513E5707.8080404@redhat.com> <87vc8wcpsm.fsf@fleche.redhat.com> <513F9576.30201@redhat.com> <87ip4vb38v.fsf@fleche.redhat.com> <5140D644.2010200@redhat.com> <87oben9har.fsf@fleche.redhat.com> <5140E73D.9010008@redhat.com> <87k3pb9fy5.fsf@fleche.redhat.com> <5140EB48.1020307@redhat.com> <87fvzx7tqf.fsf@fleche.redhat.com> In-Reply-To: <87fvzx7tqf.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00650.txt.bz2 On 14/03/13 17:54, Tom Tromey wrote: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> Originally I did do that, but the error message if you mistype an > Phil> option generated by mi_getopt is wrong: > > Phil> -stack-list-frames --no-frame-falters > Phil> ^error,msg="-stack-list-frames: Unknown option ``-no-frame-falters''" > Phil> (gdb) > > Well, it is correct, just weird :) > > Phil> I am not sure what you mean other callers, though. > > Your patch causes all other mi_getopt callers to accept "--flag" as a > synonym for "-flag". They don't do this now. > > Phil> What do you prefer? > > I think a funny error message, for MI clients only, has the least impact > of the choices we're considering Ok I have implemented this and other changes in this patch email. I'll resend with the series if there are other changes. Cheers Phil