From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5071 invoked by alias); 14 Mar 2013 14:39:35 -0000 Received: (qmail 4876 invoked by uid 22791); 14 Mar 2013 14:39:33 -0000 X-SWARE-Spam-Status: No, hits=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 14:39:16 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2EEdEeX023527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Mar 2013 10:39:14 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2EEdCY8001632; Thu, 14 Mar 2013 10:39:14 -0400 Message-ID: <5141E110.9060407@redhat.com> Date: Thu, 14 Mar 2013 14:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix the indent of using with_test_prefix References: <1363268354-30747-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1363268354-30747-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00631.txt.bz2 On 03/14/2013 01:39 PM, Yao Qi wrote: > Hi, > During the review of CTF patches, it was pointed out that the indent > of using with_test_prefix is not correct in patches, and the incorrect > usage also exists in other test cases (some of them were written by > myself). Thanks. Yeah, we discussed doing a wholesale pass like this when with_test_prefix was introduced last year, but it never happened. Until now, that is. :-) Looks good to me. -- Pedro Alves