Re: [PATCH v3 11/15] Write tsv definition in CTF and read

Tom Tromey
2013-03-12T19:56:25Z

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-03-08 Yao Qi <yao@codesourcery.com>
Yao> * ctf.c (CTF_EVENT_ID_TSV_DEF): New macro.
Yao> (ctf_save_metadata_header): Define new type alias in
Yao> metadata.
Yao> (ctf_write_header): Define new event type "tsv_def".
Yao> (ctf_write_uploaded_tsv): Write TSV to CTF.
Yao> (ctf_read_tsv): New.
Yao> (ctf_open): Call ctf_read_tsv and
Yao> merge_uploaded_trace_state_variables.
Yao> * tracepoint.c (get_uploaded_tsv): Remove 'static'.
Yao> * tracepoint.h (get_uploaded_tsv): Declare.

Yao> + 3. Uploaded trace variables. Event "tsv_def" is defined in metata,

Typo, "metadata".

Otherwise this looks ok to me.

Tom