Re: [PATCH v3 13/15] Test on saving tracepoint defs.

Yao Qi
2013-03-13T09:48:36Z

On 03/13/2013 04:10 AM, Tom Tromey wrote:
> Yao> +gdb_test "break main"
> Yao> +gdb_run_cmd
> Yao> +gdb_test "" "Breakpoint .*"
>
> I'd prefer some refactoring of gdb_run_cmd or runto instead.
> gdb_test with an empty argument has always struck me as iffy.

I'll figure out a refactor of runto to replace existing gdb_test with an
empty argument in the whole testsuite.

>
> Yao> +if ![gdb_target_supports_trace] {
> Yao> + unsupported "target does not support trace"
> Yao> + return -1;
>
> No semicolon.
>

OK, I'll fix it here and somewhere else.

> Yao> +# Restart GDB and read the trace data in tfile target.
> Yao> +gdb_exit
> Yao> +gdb_start
> Yao> +gdb_reinitialize_dir $srcdir/$subdir
> Yao> +gdb_file_cmd $binfile
>
> clean_restart?
>

proc clean_restart doesn't help here, because we need "gdb_file_cmd" in
the last step instead of "gdb_load".

--
Yao (é½å°§)