From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21876 invoked by alias); 14 Mar 2013 13:23:10 -0000 Received: (qmail 21749 invoked by uid 22791); 14 Mar 2013 13:23:08 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 13:23:01 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UG87Y-00064v-7k from Yao_Qi@mentor.com ; Thu, 14 Mar 2013 06:23:00 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 14 Mar 2013 06:22:59 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Thu, 14 Mar 2013 06:22:59 -0700 Message-ID: <5141CEF3.3070100@codesourcery.com> Date: Thu, 14 Mar 2013 13:23:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH v3 03/15] Read CTF by the ctf target References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-4-git-send-email-yao@codesourcery.com> <871ubjawq8.fsf@fleche.redhat.com> In-Reply-To: <871ubjawq8.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00627.txt.bz2 On 03/14/2013 04:08 AM, Tom Tromey wrote: > Yao> +if test "x$with_bt_include" != x; then > Yao> + LIBBABELTRACE_CFLAGS="-I$with_bt_include " > Yao> +fi > Yao> +if test "x$with_bt_lib" != x; then > Yao> + LIBBABELTRACE="-L$with_bt_lib -lbabeltrace -lbabeltrace-ctf" > Yao> +fi > Yao> + > Yao> +if test "x$with_babeltrace" != "xno"; then > > This only checks for libbabeltrace if --with-babeltrace is specified. > So, the text above about equivalency isn't really correct, at least the > way I read it; if you want to give --with-babeltrace-include, you have > to also give --with-babeltrace. > It works if we only give --with-babeltrace-include and --with-babeltrace-lib (without giving --with-babeltrace). In this case, $with_babeltrace is empty, and the condition above is still true. I tried to configure with --with-babeltrace-include=/usr/include and --with-babeltrace-lib=/usr/lib, everything looks OK. > Yao> +static int > Yao> +ctf_has_all_memory (struct target_ops *ops) > Yao> +{ > Yao> + return 0; > Yao> +} > > Unfortunately for you there is plenty of this patch I don't feel > competent to review. I don't know much about the target API. > > If nobody else looks after a decent interval, ping me and I will ok it. > I suppose if these methods parallel the existing tfile target, then that > is pretty good evidence for it being ok. Most of them are copied from tfile target, and I'll examine them (in both tfile target and ctf target) one by one. I'll give an updated version tomorrow. -- Yao (齐尧)