From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19570 invoked by alias); 13 Mar 2013 21:10:41 -0000 Received: (qmail 19412 invoked by uid 22791); 13 Mar 2013 21:10:38 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 21:10:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DLAYI4027550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 17:10:34 -0400 Received: from localhost.localdomain (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2DLAXaS014931; Wed, 13 Mar 2013 17:10:33 -0400 Message-ID: <5140EB48.1020307@redhat.com> Date: Wed, 13 Mar 2013 21:10:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes. References: <513E5707.8080404@redhat.com> <87vc8wcpsm.fsf@fleche.redhat.com> <513F9576.30201@redhat.com> <87ip4vb38v.fsf@fleche.redhat.com> <5140D644.2010200@redhat.com> <87oben9har.fsf@fleche.redhat.com> <5140E73D.9010008@redhat.com> <87k3pb9fy5.fsf@fleche.redhat.com> In-Reply-To: <87k3pb9fy5.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00611.txt.bz2 On 13/03/13 20:56, Tom Tromey wrote: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> Currently (before my patch) the commands self parse their own -- > Phil> values. One of the things from the last review was you wanted where > Phil> possible to use mi-getopt to parse options. > > Phil> It would seem weird to me to mix - and -- in these commands. > > I mean if you change the string in the mi_opt table from > "no-frame-filters" to "-no-frame-filters", then this should cause > mi_getopt to accept the "--" form without affecting other callers. > > Tom > Originally I did do that, but the error message if you mistype an option generated by mi_getopt is wrong: -stack-list-frames --no-frame-falters ^error,msg="-stack-list-frames: Unknown option ``-no-frame-falters''" (gdb) The error messages always assumes a "-". And if I was going to end up patching mi_getopt then I might as well go ahead and handle "--" options properly. I am not sure what you mean other callers, though. Other callers are not affected. "-" options work fine still, as do "--". Anyway, I have no strong feelings on this. If the error message above is fine with you we can do that, or keep the existing patch. What do you prefer? Cheers, Phil