From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13214 invoked by alias); 13 Mar 2013 20:53:29 -0000 Received: (qmail 13201 invoked by uid 22791); 13 Mar 2013 20:53:27 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 20:53:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DKrJtw000873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 16:53:19 -0400 Received: from localhost.localdomain (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2DKrHC2012596; Wed, 13 Mar 2013 16:53:18 -0400 Message-ID: <5140E73D.9010008@redhat.com> Date: Wed, 13 Mar 2013 20:53:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes. References: <513E5707.8080404@redhat.com> <87vc8wcpsm.fsf@fleche.redhat.com> <513F9576.30201@redhat.com> <87ip4vb38v.fsf@fleche.redhat.com> <5140D644.2010200@redhat.com> <87oben9har.fsf@fleche.redhat.com> In-Reply-To: <87oben9har.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00609.txt.bz2 On 13/03/13 20:27, Tom Tromey wrote: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> I do apologies, I forgot to add the mi-getopt.c patch in with the > Phil> patch-set. Here it is. > > No problem. > > It seems to me that just adding a "-" to the option string in the > callers is simpler, and probably better -- this patch makes "-" and "--" > options synonymous in all cases, but I'm not sure we want that. Currently (before my patch) the commands self parse their own -- values. One of the things from the last review was you wanted where possible to use mi-getopt to parse options. It would seem weird to me to mix - and -- in these commands. You would have: -no-frame-filters --all-values Where -no-frame-filters is parsed by mi_getopt with the single "-" and "--all-values" is parsed by the command. So I patched mi_getopt to parse "--" values for consistency. (Remember we can't use mi_getopt to parse --all-values, et al as they can be replaced with integer equivalents, ie 0, 1, 3 depending on whether it is --no-values, --all-values or --simple-values). Normally I would change this to be saner, but then we might break MI clients that reply on this integer substitution. Cheers Phil