From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99518-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29277 invoked by alias); 13 Mar 2013 18:38:33 -0000
Received: (qmail 29160 invoked by uid 22791); 13 Mar 2013 18:38:31 -0000
X-SWARE-Spam-Status: No, hits=-8.9 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 18:38:23 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DIcNS0001390	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 13 Mar 2013 14:38:23 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2DIcMPw031600;	Wed, 13 Mar 2013 14:38:22 -0400
Message-ID: <5140C79D.10006@redhat.com>
Date: Wed, 13 Mar 2013 18:38:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA PATCH] Fix completer.c FIXME, and invalid pointer to pointer conversion.
References: <20130313165042.26289.16370.stgit@brno.lan> <87mwu7b3gr.fsf@fleche.redhat.com>
In-Reply-To: <87mwu7b3gr.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00594.txt.bz2

On 03/13/2013 05:43 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> This patch removes all that dead code, then makes
> Pedro> current_demangling_style_string point to an element of
> Pedro> demangling_style_names, as the FIXME suggests, and then makes
> Pedro> current_demangling_style_string, removing the need for the 'const char
> Pedro> **' cast.
> 
> Looks good to me.

Thanks.  Applied.

-- 
Pedro Alves