From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25831 invoked by alias); 13 Mar 2013 09:48:36 -0000 Received: (qmail 25821 invoked by uid 22791); 13 Mar 2013 09:48:35 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 09:48:29 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UFiIO-0001eb-Ew from Yao_Qi@mentor.com ; Wed, 13 Mar 2013 02:48:28 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 13 Mar 2013 02:48:27 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 13 Mar 2013 02:48:26 -0700 Message-ID: <51404B27.7010601@codesourcery.com> Date: Wed, 13 Mar 2013 09:48:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH v3 13/15] Test on saving tracepoint defs. References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-14-git-send-email-yao@codesourcery.com> <874ngge5vl.fsf@fleche.redhat.com> In-Reply-To: <874ngge5vl.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00567.txt.bz2 On 03/13/2013 04:10 AM, Tom Tromey wrote: > Yao> +gdb_test "break main" > Yao> +gdb_run_cmd > Yao> +gdb_test "" "Breakpoint .*" > > I'd prefer some refactoring of gdb_run_cmd or runto instead. > gdb_test with an empty argument has always struck me as iffy. I'll figure out a refactor of runto to replace existing gdb_test with an empty argument in the whole testsuite. > > Yao> +if ![gdb_target_supports_trace] { > Yao> + unsupported "target does not support trace" > Yao> + return -1; > > No semicolon. > OK, I'll fix it here and somewhere else. > Yao> +# Restart GDB and read the trace data in tfile target. > Yao> +gdb_exit > Yao> +gdb_start > Yao> +gdb_reinitialize_dir $srcdir/$subdir > Yao> +gdb_file_cmd $binfile > > clean_restart? > proc clean_restart doesn't help here, because we need "gdb_file_cmd" in the last step instead of "gdb_load". -- Yao (齐尧)