From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 775 invoked by alias); 8 Mar 2013 19:24:36 -0000 Received: (qmail 761 invoked by uid 22791); 8 Mar 2013 19:24:33 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 19:24:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28JOMu6006380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Mar 2013 14:24:22 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28JOLxe009800 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 8 Mar 2013 14:24:22 -0500 Message-ID: <513A3AE5.5080200@redhat.com> Date: Fri, 08 Mar 2013 19:24:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Add watchpoint test with both condition and thread keywords References: <513A2F18.8000402@redhat.com> <513A31A1.6000806@redhat.com> <513A3558.1090708@redhat.com> <513A366D.9060600@redhat.com> <513A3721.1050901@redhat.com> In-Reply-To: <513A3721.1050901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00387.txt.bz2 On 03/08/2013 11:08 AM, Pedro Alves wrote: > On 03/08/2013 07:05 PM, Keith Seitz wrote: >> On 03/08/2013 11:00 AM, Keith Seitz wrote: >> >>> /me gets more coffee >> >> I should have done this BEFORE I sent the "revised" patch. :-( >> >> Sorry about that. > > Not a problem at all. > Sheesh. Wrong window/branch. Hopefully sixty-third time is the charm! Keith testsuite/ChangeLog 2013-03-08 Keith Seitz * watchpoint.exp (test_no_hw_watchpoints): Add test using both condition and thread. Then delete the watchpoint. Index: watchpoint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v retrieving revision 1.61 diff -u -p -r1.61 watchpoint.exp --- watchpoint.exp 1 Jan 2013 06:33:26 -0000 1.61 +++ watchpoint.exp 8 Mar 2013 19:23:59 -0000 @@ -814,6 +814,12 @@ proc test_no_hw_watchpoints {} { gdb_test_no_output "delete \$bpnum" "delete watch ival3" + gdb_test "watch ival3 if count > 1 thread 1 " \ + "Watchpoint \[0-9\]*: ival3.*" \ + "set slow condition watch w/thread" + + gdb_test_no_output "delete \$bpnum" "delete watch w/condition and thread" + # We've explicitly disabled hardware watches. Verify that GDB # refrains from using them. #