From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9007 invoked by alias); 8 Mar 2013 14:28:43 -0000 Received: (qmail 8995 invoked by uid 22791); 8 Mar 2013 14:28:42 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 14:28:34 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28ESUKA020691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Mar 2013 09:28:30 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28ESS71006761; Fri, 8 Mar 2013 09:28:29 -0500 Message-ID: <5139F58C.60909@redhat.com> Date: Fri, 08 Mar 2013 14:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: "Abid, Hafiz" CC: gdb-patches@sourceware.org, stan@codesourcery.com, yao@codesourcery.com, eliz@gnu.org Subject: Re: [patch] Change trace buffer size(v5) References: <1362742183.28338.0@abidh-ubunto1104> In-Reply-To: <1362742183.28338.0@abidh-ubunto1104> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00369.txt.bz2 On 03/08/2013 11:29 AM, Abid, Hafiz wrote: > Hi Pedro, >> It's always good for the submission to be explicit in these >> things, and good to consider these issues upfront. I'm interested >> in hearing your thoughts on the subject upfront, and the plans >> you had, if any. >> >> I gave it some thought, and looked at the code to refresh a bit, >> and I think things will still work correctly if the IPA buffer is >> either smaller or larger than gdbserver's. >> >> Running the whole set of gdb.trace tests (--directory=gdb.trace) >> with a gdbserver and IPA hacked to default to different >> buffer sizes once would provide some assurance, though >> not that much. > I have run the test cases as you mentioned and did not see any > regression. Thanks. > + sval = (LONGEST)val; Space after cast. > + > +set BUFFER_SIZE 4 > +set default_size -1 > + > +# Save default trace buffer size in 'default_size'. Add: set test "get default buffer size" > +gdb_test_multiple "tstatus" "tstatus check 1" { Make this: gdb_test_multiple "tstatus" $test > + -re ".*Trace buffer has ($decimal) bytes of ($decimal) bytes free.*" { > + set default_size $expect_out(2,string) Add: pass $test > + } > +} > + > +# If we did not get the default size then there is no point in running the > +# tests below. > +if { $default_size < 0 } { > + fail "Get default buffer size." and remove this "fail" (watch for lowercase). gdb_test_multiple will have already called FAIL with its second argument on failure. > + return -1; > +} OK with these fixes. Thanks, -- Pedro Alves