From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11095 invoked by alias); 8 Mar 2013 00:22:35 -0000 Received: (qmail 11087 invoked by uid 22791); 8 Mar 2013 00:22:33 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 00:22:25 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r280MOso001024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Mar 2013 19:22:24 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r280MN23020651; Thu, 7 Mar 2013 19:22:24 -0500 Message-ID: <51392F3F.5090102@redhat.com> Date: Fri, 08 Mar 2013 00:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] "constify" parse_exp_1 References: <51392C56.7040302@redhat.com> In-Reply-To: <51392C56.7040302@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00324.txt.bz2 On 03/08/2013 12:09 AM, Keith Seitz wrote: > --- ada-lang.c 5 Mar 2013 21:15:34 -0000 1.394 > +++ ada-lang.c 7 Mar 2013 22:59:29 -0000 > @@ -4057,13 +4057,14 @@ ada_read_renaming_var_value (struct symb > struct block *block) > { > char *sym_name; > + const char *sname; > struct expression *expr; > struct value *value; > struct cleanup *old_chain = NULL; > > - sym_name = xstrdup (SYMBOL_LINKAGE_NAME (renaming_sym)); > + sname = sym_name = xstrdup (SYMBOL_LINKAGE_NAME (renaming_sym)); > old_chain = make_cleanup (xfree, sym_name); > - expr = parse_exp_1 (&sym_name, 0, block, 0); > + expr = parse_exp_1 (&sname, 0, block, 0); > make_cleanup (free_current_contents, &expr); > value = evaluate_expression (expr); > I didn't get past the first hunk in the patch. :-) The xstrdup seemed to be there _because_ parse_exp_1 changed the input string. It seems it can be removed now. Your patch seems to make sym_name unused, even. There may be more instances of this in the patch. /me off to bed. :-) -- Pedro Alves