From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] cleanup: while (isspace) -> skip_spaces{,_const}
Date: Thu, 07 Mar 2013 17:20:00 -0000 [thread overview]
Message-ID: <5138CC61.5070002@redhat.com> (raw)
In-Reply-To: <5138CAC7.8060503@redhat.com>
On 03/07/2013 05:13 PM, Keith Seitz wrote:
> On 03/07/2013 08:39 AM, Pedro Alves wrote:
>
>> This now continues forward even if *addr_exp is '\0',
>> while before the patch it didn't.
>
> Yes, that's right, it is a subtle change that I missed because...
>
>> And it seems to be we'll now reach that last error in that
>> case, while we wouldn't before. Can we trigger that with
>> "info register rip ", say?
>
> ...it has no effect. In execute_command, top.c:461, the command parser strips trailing whitespace.
Thanks, I keep forgetting that.
> I can add a check for *addr_exp == '\0' again, if you'd like.
Fine with me to leave it be. I was going to suggest a
gdb_assert, but the normal error already catches this,
and we can react then if some caller behaves differently.
--
Pedro Alves
next prev parent reply other threads:[~2013-03-07 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 1:34 Keith Seitz
2013-03-07 15:18 ` Tom Tromey
2013-03-07 16:39 ` Pedro Alves
2013-03-07 17:13 ` Keith Seitz
2013-03-07 17:20 ` Pedro Alves [this message]
2013-03-07 21:58 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5138CC61.5070002@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox