Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mircea Gherzan <mircea.gherzan@intel.com>
To: "André Pönitz" <andre.poenitz@mathematik.tu-chemnitz.de>
Cc: tromey@redhat.com, vladimir@codesourcery.com,
	 marc.khouzam@ericsson.com, gdb-patches@sourceware.org,
	 mgherzan@gmail.com
Subject: Re: [PATCH 1/3] MI: fix the result of -break-insert with multiple locations
Date: Thu, 07 Mar 2013 16:32:00 -0000	[thread overview]
Message-ID: <5138C0F7.6060703@intel.com> (raw)
In-Reply-To: <20130302165337.GA8432@klara.mpi.htwm.de>

On 02.03.2013 17:53, André Pönitz wrote:
> On Thu, Feb 28, 2013 at 07:29:55PM +0100, Mircea Gherzan wrote:
>> The current MI output when printing a breakpoint with multiple locations
>> is not conformant to the MI specification:
>>
>>    bkpt={number="1", ...},{number="1.1", ...},{number="1.2", ...}
>>
>> This patch fixes this issue by moving the locations to a list inside the
>> first tuple:
>>
>>    bkpt={number="1", ... , locations=[{number="1.1", ...}, ...]}
>
> This breaks GDB frontends that parse the original output.

This has been discussed before. Marc has confirmed that Eclipse does not 
parse the original output either. With this patch series, the printing 
of breakpoints with multiple locations is:
   A) conformant to the MI syntax
   B) documented
   C) tested

With some review this should make it into 7.6.

Thanks,
Mircea

-- 

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-03-07 16:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 18:30 Mircea Gherzan
2013-02-28 18:50 ` [PATCH 2/3] MI: add tests for breakpoints " Mircea Gherzan
2013-02-28 18:56 ` [PATCH 3/3] MI: document the format " Mircea Gherzan
2013-02-28 18:59   ` Eli Zaretskii
2013-03-02 16:53 ` [PATCH 1/3] MI: fix the result of -break-insert " André Pönitz
2013-03-07 16:32   ` Mircea Gherzan [this message]
2013-03-07 20:54     ` André Pönitz
2013-03-07 21:44       ` Marc Khouzam
2013-03-08  0:15         ` André Pönitz
2013-03-11 15:06           ` Mircea Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5138C0F7.6060703@intel.com \
    --to=mircea.gherzan@intel.com \
    --cc=andre.poenitz@mathematik.tu-chemnitz.de \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=mgherzan@gmail.com \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox