From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12478 invoked by alias); 7 Mar 2013 15:41:50 -0000 Received: (qmail 12469 invoked by uid 22791); 7 Mar 2013 15:41:49 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 15:41:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r27Ffe5j031379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Mar 2013 10:41:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r27FfbFb032252; Thu, 7 Mar 2013 10:41:38 -0500 Message-ID: <5138B531.2050603@redhat.com> Date: Thu, 07 Mar 2013 15:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: "Metzger, Markus T" CC: Jan Kratochvil , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "Himpel, Christian" Subject: Re: Crash of GDB with gdbserver btrace enabled [Re: [patch v9 00/23] branch tracing support for Atom] References: <20130306124334.GA29994@host2.jankratochvil.net> <20130306170622.GA25771@host2.jankratochvil.net> <20130307090632.GA11095@host2.jankratochvil.net> <20130307101350.GA14969@host2.jankratochvil.net> <20130307120644.GA21253@host2.jankratochvil.net> <5138AE4C.3060801@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00298.txt.bz2 On 03/07/2013 03:31 PM, Metzger, Markus T wrote: > On a related topic, remote.c calls pop_target at various places, e.g. > in readchar when the communication breaks down. It looks to me > as if it assumes that it is the topmost target. > > If communication breaks down during remote recording, wouldn't > this pop the record target instead of the remote target? Yes. record + gdbserver isn't much used I assume, as I've known about that for ages, but never heard anyone complain. Another similar issue in spirit is the to_stratum checks in record.c: static void cmd_record_delete (char *args, int from_tty) { if (current_target.to_stratum == record_stratum) That assumes the record target is always the topmost. Nowadays we have arch_stratum on top of record. Only used by Cell nowadays, so it's latent. -- Pedro Alves