From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29459 invoked by alias); 7 Mar 2013 14:36:47 -0000 Received: (qmail 29314 invoked by uid 22791); 7 Mar 2013 14:36:46 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 14:36:38 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UDbvx-0004eB-P4 from Yao_Qi@mentor.com ; Thu, 07 Mar 2013 06:36:37 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 7 Mar 2013 06:36:36 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Thu, 7 Mar 2013 06:36:37 -0800 Message-ID: <5138A5CC.5070301@codesourcery.com> Date: Thu, 07 Mar 2013 14:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Marc Khouzam CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/4] Fix dprintf bugs References: <1361192891-29341-1-git-send-email-yao@codesourcery.com> <1362057362-25324-1-git-send-email-yao@codesourcery.com> ,<513837B9.2070101@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00287.txt.bz2 On 03/07/2013 10:05 PM, Marc Khouzam wrote: > I was actually thinking of keeping the hit count being updated but > simply not sending the MI event for it. I'm under the impression > that updating the hit count is not expensive, so having that information > available can be useful. What bothers me is the very many MI > events being sent to the frontend. If the hit count is not reported > by an MI event for dprintf, its value can still be obtained by > the frontend through -break-list for example. FAOD, are you suggesting that we still update hit count, but don't have to notify breakpoint-modified observer? > > For the agent-style dprintf though, I'm guessing that the hit count > is not being updated to avoid communication with GDB? This > scenario already had to be handled for normal breakpoints and > I suggest using whatever scheme is already being used. We can use async remote notification here, to notify GDB that the hit count or other attributes of breakpoint/tracepoint are modified. I've had some local patches to report to GDB that the hit count and traceframe usage of tracepoint is updated. After pending async remote notification are patches approved, I'll post them out. -- Yao (齐尧)