From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13678 invoked by alias); 6 Mar 2013 21:57:16 -0000 Received: (qmail 13670 invoked by uid 22791); 6 Mar 2013 21:57:15 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 21:57:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26LvBQa030646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Mar 2013 16:57:12 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r26LvAXi012958 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 6 Mar 2013 16:57:11 -0500 Message-ID: <5137BBB6.30009@redhat.com> Date: Wed, 06 Mar 2013 21:57:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Constify gen_printf/ax_string References: <51379F85.4050005@redhat.com> <87vc94i4ea.fsf@fleche.redhat.com> In-Reply-To: <87vc94i4ea.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00247.txt.bz2 On 03/06/2013 01:50 PM, Tom Tromey wrote: > Keith> I will be submitting a patch to constify parse_exp_1. > > Wow, that must've been a lot of work. Well, not entirely. This is just the first round. All I did is xstrdup the input to parse_exp_1 and pass that *as is* to the subroutines. My plan is to keep pushing this down as much as possible as an attempt to get things going at least in a piecemeal/manageable way. YMMV. I have a local branch here that I have modified the parsers and a bunch of other stuff, too. That patch is already quadruple the size of the this (as yet unsubmitted) patch. With that, there is still a phenomenal amount of work to do, but I will keep plugging away at it as time permits. Keith