Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: kevinb@cygnus.com
Cc: msnyder@cygnus.com, jimb@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFA] breakpoint.c: More check_duplicates() changes.
Date: Sat, 12 May 2001 03:15:00 -0000	[thread overview]
Message-ID: <5137-Sat12May2001131511+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <1010512080125.ZM29521@ocotillo.lan>

> Date: Sat, 12 May 2001 01:01:25 -0700
> From: Kevin Buettner <kevinb@cygnus.com>
>  
> +/* Return true for all breakpoint types which are permitted to have
> +   addresses which may be a duplicate of some other breakpoint.  E.g,
> +   watchpoints will always have zero valued addresses and we don't
> +   want check_duplicates() to mark a watchpoint as a duplicate of an
> +   actual breakpoint at address zero.  */
> +
> +static int
> +duplicate_okay (struct breakpoint *bpt)
> +{
> +  enum bptype type = bpt->type;
> +
> +  return type == bp_watchpoint
> +         || type == bp_hardware_watchpoint
> +	 || type == bp_read_watchpoint
> +	 || type == bp_access_watchpoint
> +	 || type == bp_catch_exec
> +	 || type == bp_longjmp_resume
> +	 || type == bp_catch_fork
> +	 || type == bp_catch_vfork;
> +}
> +

Is it perhaps possible to explain, for each of these types, why it is
okay to duplicate it?  The comment only gives one example.


  reply	other threads:[~2001-05-12  3:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-12  1:01 Kevin Buettner
2001-05-12  3:15 ` Eli Zaretskii [this message]
2001-05-12  3:24 ` Mark Kettenis
2001-05-18 16:56 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5137-Sat12May2001131511+0300-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    --cc=kevinb@cygnus.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox