From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24307 invoked by alias); 6 Mar 2013 00:11:45 -0000 Received: (qmail 24289 invoked by uid 22791); 6 Mar 2013 00:11:42 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-junco.atl.sa.earthlink.net (HELO elasmtp-junco.atl.sa.earthlink.net) (209.86.89.63) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 00:11:37 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-junco.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1UD1xI-00023K-EC for gdb-patches@sourceware.org; Tue, 05 Mar 2013 19:11:36 -0500 Message-ID: <513689B3.8030409@earthlink.net> Date: Wed, 06 Mar 2013 00:11:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130216 Thunderbird/17.0.3 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't need fast tracepoint in tstatus.exp References: <1362412004-23628-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1362412004-23628-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da94019d406861859d44e2c34973f21eccf26350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00192.txt.bz2 On 3/4/13 7:46 AM, Yao Qi wrote: > tstatus.exp is used to test the output of 'tstatus' but there are some > tests on fast tracepoint in it, which is not related to tstatus. This > patch is to remove these fast tracepoint related stuff from tstatus.exp. Even going back through old mail and notes, I simply cannot remember why using fast tracepoints here seemed like a good idea. It doesn't even look like a cut-n-paste from elsewhere, since there are small differences from other uses. About the only thing I can think of is that sometimes I want to mix up features a little in the testsuite, so as to do double duty as unit test and integration test (which sounds a little foolish now that I see it written down :-) ). In any case, fast tracepoints do look like a distraction from the business of tstatus testing, so I'm OK with this change. Stan stan@codesourcery.com > > gdb/testsuite: > > 2013-03-04 Yao Qi > > * gdb.trace/tstatus.exp: Use prepare_for_testing. > (test_tracepoints): Don't set fast tracepoint. > (top level): Don't check agent library is loaded or not. > --- > gdb/testsuite/gdb.trace/tstatus.exp | 41 +++------------------------------- > 1 files changed, 4 insertions(+), 37 deletions(-) > > diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp > index 8a0bbdf..483bb20 100644 > --- a/gdb/testsuite/gdb.trace/tstatus.exp > +++ b/gdb/testsuite/gdb.trace/tstatus.exp > @@ -34,22 +34,14 @@ if ![gdb_target_supports_trace] { > return -1 > } > > -set libipa [get_in_proc_agent] > -gdb_load_shlibs $libipa > - > -# Can't use prepare_for_testing, because that splits compiling into > -# building objects and then linking, and we'd fail with "linker input > -# file unused because linking not done" when building the object. > - > -if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ > - executable [list debug shlib=$libipa] ] != "" } { > - untested "failed to compile ftrace tests" > +if [prepare_for_testing $expfile $executable $srcfile \ > + {debug nowarnings} ] { > + untested "failed to compile tracepoint tests" > return -1 > } > -clean_restart ${executable} > > if ![runto_main] { > - fail "Can't run to main for ftrace tests" > + fail "Can't run to main for tracepoint tests" > return 0 > } > > @@ -141,34 +133,9 @@ proc test_tracepoints {} { > gdb_trace_setactions "collect at set_point: define actions" \ > "" \ > "collect parm" "^$" > - set fastgood 0 > - > - gdb_test_multiple "ftrace gdb_recursion_test" "set fast tracepoint" { > - -re "May not have a fast tracepoint at .*\r\n$gdb_prompt $" { > - pass "4-byte fast tracepoint could not be set" > - } > - -re "Fast tracepoint .*\r\n$gdb_prompt $" { > - pass "4-byte fast tracepoint is set" > - set fastgood 1 > - } > - } > - > - if { $fastgood } { > - > - gdb_trace_setactions "collect at four_byter: define actions" \ > - "" \ > - "collect globvar, anarg" "^$" > - } > > run_trace_experiment > > } > > -gdb_reinitialize_dir $srcdir/$subdir > - > -if { [gdb_test "info sharedlibrary" ".*${libipa}.*" "IPA loaded"] != 0 } { > - untested "Could not find IPA lib loaded" > - return 1 > -} > - > test_tracepoints >