From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21336 invoked by alias); 5 Mar 2013 04:52:29 -0000 Received: (qmail 21326 invoked by uid 22791); 5 Mar 2013 04:52:27 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 04:52:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UCjrN-0000Da-Mo from Yao_Qi@mentor.com ; Mon, 04 Mar 2013 20:52:17 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 4 Mar 2013 20:52:17 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 4 Mar 2013 20:52:00 -0800 Message-ID: <513579D4.6040000@codesourcery.com> Date: Tue, 05 Mar 2013 04:52:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] Don't need fast tracepoint in tstatus.exp References: <1362412004-23628-1-git-send-email-yao@codesourcery.com> <5134CFEC.7070902@redhat.com> In-Reply-To: <5134CFEC.7070902@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00134.txt.bz2 On 03/05/2013 12:46 AM, Pedro Alves wrote: >> tstatus.exp is used to test the output of 'tstatus' but there are some >> >tests on fast tracepoint in it, which is not related to tstatus. This >> >patch is to remove these fast tracepoint related stuff from tstatus.exp. > Can we assume > The reason why fast tracepoint stuff was added into tstatus.exp is unclear to me. It was not mentioned in the mail posting this patch. However, I can't see how fast tracepoint affects the output of 'tstatus', so I propose this patch to remove them. > If we aren't doing any fast tracepoint tests, then is > there a reason to keep this prepare_for_testing and > runto_main instead of removing them altogether? OK, the prepare_for_testing and runto_main are removed. -- Yao (齐尧) gdb/testsuite: 2013-03-05 Yao Qi * gdb.trace/tstatus.exp: Remove the invocation to gdb_load_shlibs, gdb_compile, clean_restart and runto_main. (test_tracepoints): Don't set fast tracepoint. (top level): Don't check agent library is loaded or not. --- gdb/testsuite/gdb.trace/tstatus.exp | 44 ----------------------------------- 1 files changed, 0 insertions(+), 44 deletions(-) diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp index 8a0bbdf..3be3b86 100644 --- a/gdb/testsuite/gdb.trace/tstatus.exp +++ b/gdb/testsuite/gdb.trace/tstatus.exp @@ -34,25 +34,6 @@ if ![gdb_target_supports_trace] { return -1 } -set libipa [get_in_proc_agent] -gdb_load_shlibs $libipa - -# Can't use prepare_for_testing, because that splits compiling into -# building objects and then linking, and we'd fail with "linker input -# file unused because linking not done" when building the object. - -if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ - executable [list debug shlib=$libipa] ] != "" } { - untested "failed to compile ftrace tests" - return -1 -} -clean_restart ${executable} - -if ![runto_main] { - fail "Can't run to main for ftrace tests" - return 0 -} - proc run_trace_experiment {} { global gdb_prompt global decimal @@ -141,34 +122,9 @@ proc test_tracepoints {} { gdb_trace_setactions "collect at set_point: define actions" \ "" \ "collect parm" "^$" - set fastgood 0 - - gdb_test_multiple "ftrace gdb_recursion_test" "set fast tracepoint" { - -re "May not have a fast tracepoint at .*\r\n$gdb_prompt $" { - pass "4-byte fast tracepoint could not be set" - } - -re "Fast tracepoint .*\r\n$gdb_prompt $" { - pass "4-byte fast tracepoint is set" - set fastgood 1 - } - } - - if { $fastgood } { - - gdb_trace_setactions "collect at four_byter: define actions" \ - "" \ - "collect globvar, anarg" "^$" - } run_trace_experiment } -gdb_reinitialize_dir $srcdir/$subdir - -if { [gdb_test "info sharedlibrary" ".*${libipa}.*" "IPA loaded"] != 0 } { - untested "Could not find IPA lib loaded" - return 1 -} - test_tracepoints -- 1.7.7.6