From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2811 invoked by alias); 1 Mar 2013 15:59:50 -0000 Received: (qmail 2802 invoked by uid 22791); 1 Mar 2013 15:59:49 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 15:59:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r21Fxgjh013576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Mar 2013 10:59:42 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r21Fxd1Q004958; Fri, 1 Mar 2013 10:59:39 -0500 Message-ID: <5130D06A.9000701@redhat.com> Date: Fri, 01 Mar 2013 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jiong Wang CC: Yao Qi , Joel Brobecker , gdb-patches@sourceware.org, Walter Lee Subject: Re: [RFC/TileGX 2/6] simplify the handling of skip prologue for plt stub References: <50F91516.6010204@tilera.com> <20130118131511.GF3564@adacore.com> <50F9664D.2090008@tilera.com> <511F0FE9.8030300@codesourcery.com> <51243991.4040304@tilera.com> <51244CBA.4000009@codesourcery.com> <512623BE.2030608@tilera.com> <51309167.5050608@redhat.com> <5130B63A.1060304@tilera.com> In-Reply-To: <5130B63A.1060304@tilera.com> Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00026.txt.bz2 On 03/01/2013 02:07 PM, Jiong Wang wrote: > > * tilegx-tdep.c (tilegx_analyze_prologue): Improve the evaluation > of "instbuf_size". > (tilegx_skip_prologue): Improve the evaluation of the end address > for prologue analyze. "improve" is a "Why?", and subjective. ChangeLogs are objective, and document the "What" changed. I suggest: * tilegx-tdep.c (tilegx_analyze_prologue): Limit bundle reading to END_ADDR. (tilegx_skip_prologue): Limit prologue analysis to section end. > tilegx_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR start_pc) > { > - CORE_ADDR func_start; > + CORE_ADDR func_start, end_pc; > + struct obj_section *s = NULL; No need to initialize 's' here, it's unconditionally initialized below. > + s = find_pc_section (start_pc); OK with these changes. Thanks. -- Pedro Alves