From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14577 invoked by alias); 1 Mar 2013 10:33:43 -0000 Received: (qmail 14567 invoked by uid 22791); 1 Mar 2013 10:33:43 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RP_MATCHES_RCVD,TW_EG,TW_GJ X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 10:33:38 +0000 Received: from localhost.localdomain (124.207.145.166) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.722.0; Fri, 1 Mar 2013 05:33:37 -0500 Message-ID: <513083FD.5020205@tilera.com> Date: Fri, 01 Mar 2013 10:33:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [RFC/TileGX] fix longjmp bug References: <51307BBA.3090202@tilera.com> <5130836B.7090505@redhat.com> In-Reply-To: <5130836B.7090505@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00009.txt.bz2 On 03/01/2013 06:31 PM, Pedro Alves wrote: > Thanks. > >> gdb/ChangeLog: >> >> * tilegx-tdep.c (tilegx_get_longjmp_target): New function. >> (tilegx_gdbarch_init): Install it. >> > OK with the issues pointed out below fixed. > >> +/* This is the implementation of gdbarch method get_longjmp_target. */ >> + >> +static int >> +tilegx_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc) >> +{ >> + struct gdbarch *gdbarch = get_frame_arch (frame); >> + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); >> + CORE_ADDR jb_addr; >> + char buf[8]; > s/char/gdb_byte/. > >> + >> + jb_addr = get_frame_register_unsigned (frame, TILEGX_R0_REGNUM); >> + >> + /* TileGX jmp_buf contains 32 elements of type __uint_reg_t which >> + is size of 8bytes, the return address is stored in the 25th slot. */ > Grammar: > > /* TileGX's jmp_buf contains 32 elements of type __uint_reg_t which > has a size of 8 bytes. The return address is stored in the 25th > slot. */ > >> + if (target_read_memory (jb_addr + 25 * 8, buf, 8)) > should be single space ---------------^ > > OK with these issues fixed. thanks for review ! -- Regards, Jiong. Wang Tilera Corporation.