Re: [PATCH 3/5] Read CTF by the ctf target

Hui Zhu
2013-03-01T02:38:13Z

On Fri, Mar 1, 2013 at 1:18 AM, Pedro Alves <palves@redhat.com> wrote:
> (not a complete review)
>
> On 02/27/2013 02:17 AM, Yao Qi wrote:
>
>> +if test "x$with_babeltrace" != "xno"; then
>> + saved_CFLAGS="$CFLAGS"
>> + CFLAGS="$CFLAGS $btinc"
>> + AC_MSG_CHECKING([for babeltrace])
>> + AC_TRY_COMPILE([
>> +#include <babeltrace/babeltrace.h>
>> +#include <babeltrace/ctf/events.h>
>> +#include <babeltrace/ctf/iterator.h>
>
> We know from previous patches that the latest released
> babeltrace breaks gdb, due to the lookup_enum function. Does
> this catch that? I see namespacing fixes going into
> babeltrace as recently as last 15th. Do we know if
> babeltrace's API is more or less done and close to a release?

Hi Mathieu,

Could you help us with this question?

Thanks,
Hui

>
>> + ],[],
>> + [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])],
>> + [AC_MSG_RESULT([no]); btlibs= ; btinc= ])
>> + CFLAGS="$saved_CFLAGS"
>> +fi
>> +
>> +# Flags needed for UST
>
> babeltrace
>
>> +AC_SUBST(btlibs)
>> +AC_SUBST(btinc)
>> +
>
> --
> Pedro Alves
>