From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24826 invoked by alias); 28 Feb 2013 17:19:14 -0000 Received: (qmail 24814 invoked by uid 22791); 28 Feb 2013 17:19:12 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 17:19:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1SHJ0hF022041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Feb 2013 12:19:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1SHIw6k016382; Thu, 28 Feb 2013 12:18:59 -0500 Message-ID: <512F9182.3080104@redhat.com> Date: Thu, 28 Feb 2013 17:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Read CTF by the ctf target References: <1361931459-3953-1-git-send-email-yao@codesourcery.com> <1361931459-3953-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1361931459-3953-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00751.txt.bz2 (not a complete review) On 02/27/2013 02:17 AM, Yao Qi wrote: > +if test "x$with_babeltrace" != "xno"; then > + saved_CFLAGS="$CFLAGS" > + CFLAGS="$CFLAGS $btinc" > + AC_MSG_CHECKING([for babeltrace]) > + AC_TRY_COMPILE([ > +#include > +#include > +#include We know from previous patches that the latest released babeltrace breaks gdb, due to the lookup_enum function. Does this catch that? I see namespacing fixes going into babeltrace as recently as last 15th. Do we know if babeltrace's API is more or less done and close to a release? > + ],[], > + [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])], > + [AC_MSG_RESULT([no]); btlibs= ; btinc= ]) > + CFLAGS="$saved_CFLAGS" > +fi > + > +# Flags needed for UST babeltrace > +AC_SUBST(btlibs) > +AC_SUBST(btinc) > + -- Pedro Alves