Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Sanimir Agovic <sanimir.agovic@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] add-inferior: expand tilde in -exec FILENAME argument
Date: Thu, 28 Feb 2013 15:54:00 -0000	[thread overview]
Message-ID: <512F7897.5000705@redhat.com> (raw)
In-Reply-To: <1362062885-6620-1-git-send-email-sanimir.agovic@intel.com>

Thanks.

On 02/28/2013 02:48 PM, Sanimir Agovic wrote:
> I could not come up with a solid testcase, hints are welcome.

Not sure either.

I assume this fixes:

(gdb) add-inferior -exec ~/gdb/tests/main
Added inferior 2
~/gdb/tests/main: No such file or directory.

even though the file does exist.

I wondered if other similar places expand the tilde early
or just before file open, and confirmed that at least "file"
and "info files" have expanded the tilde before any visible
strings is shown:

(gdb) file ~/gdb/tests/main
Load new symbol table from "/home/pedro/gdb/tests/main"? (y or n)

(gdb) info files
Symbols from "/home/pedro/gdb/tests/main".
Local exec file:
        `/home/pedro/gdb/tests/main', file type elf64-x86-64.

> 2013-02-28  Sanimir Agovic  <sanimir.agovic@intel.com>
> 
> 	* inferior.c: Include "readline/readline.h".
> 	(add_inferior_command): Tilde expand filename.

OK.

Thanks again for the patch.

-- 
Pedro Alves


  reply	other threads:[~2013-02-28 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 15:44 Sanimir Agovic
2013-02-28 15:54 ` Pedro Alves [this message]
2013-02-28 17:20   ` Agovic, Sanimir
2013-05-30  9:25     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512F7897.5000705@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanimir.agovic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox