From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6280 invoked by alias); 27 Feb 2013 15:23:21 -0000 Received: (qmail 6265 invoked by uid 22791); 27 Feb 2013 15:23:19 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 15:23:10 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1RFN6bE002544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Feb 2013 10:23:06 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1RFN4nh013958; Wed, 27 Feb 2013 10:23:05 -0500 Message-ID: <512E24D8.3040206@redhat.com> Date: Wed, 27 Feb 2013 15:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Check trace data from trace file References: <1361761061-9625-1-git-send-email-yao@codesourcery.com> <512AD5CA.50606@codesourcery.com> <512D0593.2060501@redhat.com> <512D6702.7020900@codesourcery.com> In-Reply-To: <512D6702.7020900@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00684.txt.bz2 On 02/27/2013 01:53 AM, Yao Qi wrote: > On 02/27/2013 02:44 AM, Pedro Alves wrote:> On 02/25/2013 03:08 AM, Yao Qi wrote: >>>> Here is the same patch with spaces ignored. It is easier to read. >>>> Note that I modified a matched pattern "PC register is not >>>> available" for tfile target, as the regcache is not available when >>>> switch to tfind mode (no regcache has been read out of 'R' block yet). >> Hmmm. Not sure. Shouldn't something have caught that exception? IOW, >> could that be a bug? >> >> I'm having difficulty figuring it out, because when I run the test >> I don't see that output anywhere in the gdb.log: >> >> (gdb) printf "x %d x\n", $tracepoint >> x 2 x >> (gdb) PASS: gdb.trace/report.exp: tfile: 9.1: find frame for TP 2 >> tdump >> Data collected at tracepoint 2, trace frame 0: >> (gdb) PASS: gdb.trace/report.exp: tfile: 9.1: tdump, nothing collected >> >> I wonder what's different in our environments. >> > > Yeah, it shows up in one build server. I tried the test on my laptop > (Fedora 16) and the other build server, it is OK. Then, I get rid of > the pattern to match "PC register is not available". I'll check it > on that build server. Thanks. > The changelog entry is completed as you suggested (wo/ "top level"). I'd prefer keeping it actually. It's there to disambiguate with the case of the new line of text being a continuation of the previous context, that happens to end up on a new line just because that's how the text flowed. Like: (foo_function_foo): New blah foo bar yum foo foo foo. Call use_collected_data once on the live target. What called "use_collected_data"? foo_function_foo, or the top level? Otherwise this version is OK. Thanks. -- Pedro Alves