From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18342 invoked by alias); 27 Feb 2013 14:10:39 -0000 Received: (qmail 18325 invoked by uid 22791); 27 Feb 2013 14:10:37 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RP_MATCHES_RCVD,TW_EG X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 14:10:31 +0000 Received: from [192.168.0.102] (218.11.179.49) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.722.0; Wed, 27 Feb 2013 09:10:29 -0500 Message-ID: <512E13D0.6010008@tilera.com> Date: Wed, 27 Feb 2013 14:10:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Pedro Alves CC: , Walter Lee Subject: Re: [RFC/TileGX 2/2] fix gdbserver bug for 32bit elf References: <5110E21A.2060308@tilera.com> <512CFA08.6060507@redhat.com> <512D8B11.7080904@tilera.com> <512E12DF.9070401@redhat.com> In-Reply-To: <512E12DF.9070401@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00681.txt.bz2 于 2013/2/27 22:06, Pedro Alves 写道: > On 02/27/2013 04:26 AM, Jiong Wang wrote: >> at 2013/2/27 2:08, Pedro Alves written: >>> You mention the 'pc' as a pseudo register. At the >>> hardware/kernel level, on tilegx32, is 'pc' 32-bit or 64-bit? >>> I thought Tile-GX was always 64-bit, and tilegx32 was just an ABI. >> thanks for review these. >> >> yes, exactly, TileGX is always 64bit. On tilegx32, at hardware/kernel level, 'pc' is 64bit. >>> Is the kernel already trimming the PC? >> No trimming, the kernel always return 64bit. > Oh well. Makes me feel even more this isn't the best approach, but, > >> below is the updated ChangeLog, and patch. >> >> please review. thanks. >> >> gdb/ >> >> * regformats/reg-tilegx.dat (name): Change abi name to "tilegx". >> * regformats/reg-tilegx32.dat: New. >> >> gdb/gdbserver/ >> >> * Makefile.in (clean): Remove reg-tilegx.c, reg-tilegx32.c. >> (reg-tilegx32.c): New rule. >> * configure.srv (tilegx-*-linux*): Add reg-tilegx32.o to srv_regobj. >> * linux-tile-low.c (tile_arch_steup): New function. Invoke > Typo: "setup". > >> different register info initializer according to elf class. >> (init_registers_tilgx32): New function. The tilegx32 register info >> initializer. >> (tile_fill_gregset): Use "uint_reg_t" to represent register size. >> (tile_store_gregset): Likewise. > OK. thanks, I will commit this after fixing typo. Regards, Jiong >