From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22782 invoked by alias); 22 Feb 2013 19:43:40 -0000 Received: (qmail 22772 invoked by uid 22791); 22 Feb 2013 19:43:39 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 19:43:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1MJhR4W011353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Feb 2013 14:43:27 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1MJhQWZ003409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Feb 2013 14:43:26 -0500 Message-ID: <5127CA5E.5090201@redhat.com> Date: Fri, 22 Feb 2013 19:43:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Tom Tromey CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [RFA] fix disassemble foo::bar::~bar References: <87sj4p9xp9.fsf@fleche.redhat.com> <5126B48A.1080903@redhat.com> <87k3q088iv.fsf@fleche.redhat.com> In-Reply-To: <87k3q088iv.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00599.txt.bz2 On 02/22/2013 11:15 AM, Tom Tromey wrote: > Keith> The above patch fixes Doug's test cases and also is regression-free on > Keith> native x86_64-unknown-linux (Fedora 15). > > I tend to think this is preferable. At least, as long as we have to > keep destructor_name_p. I was only attempting to point out a simpler alternative. As you rightly point out, though, it is debatable whether destructor_name_p is needed at all. As it is right now (with Doug's or my patch) we get, (gdb) p foo::~bar name of destructor must equal name of class How much more useful is that than (gdb) p foo::~bar There is no field named ~bar IMO, the second error is at least as useful, if not more so, than what we have now. Since destructor_name_p is only used in this one place, I would urge you/Doug to consider just nuking it and the test in c-exp.y > This patch is ok with me, if it includes Doug's test case, though I'd > like to hear from Doug about it as well. I left the choice up to Doug. It's his ball after all. Keith