From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15338 invoked by alias); 16 Jul 2018 13:33:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15326 invoked by uid 89); 16 Jul 2018 13:33:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=hold, wondered, H*Ad:U*palves X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 13:33:30 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A0A84002248; Mon, 16 Jul 2018 13:33:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D13C2156893; Mon, 16 Jul 2018 13:33:27 +0000 (UTC) Subject: Re: [RFA 01/13] Simple unused variable removals To: Tom Tromey , Simon Marchi References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-2-tom@tromey.com> <87b519fc-318a-84aa-7ced-aea354f059fb@simark.ca> <87in5i9ej4.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <51240093-05e2-7294-7ffd-a893c9147b53@redhat.com> Date: Mon, 16 Jul 2018 13:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87in5i9ej4.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00472.txt.bz2 On 07/14/2018 01:40 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4, > Simon> - 4, byte_order); > > Simon> I wondered this was a bug (should that variable really be used), but I > Simon> wouldn't know without some quite extensive research... so all-in-all, LGTM. > > Yes, this one was on the bubble and I almost put it in its own patch... > I can't recall offhand if there were others like this. I skimmed the patch and it looks good to me to, and, that bit also gave me pause. I was wondering whether we should replace it with a comment, saying that we're skipping 4 bytes which hold the entry's size. That might save someone some time in case the size turns out to be needed. (I have no idea where the structure being extracted is documented, for example.) Thanks, Pedro Alves