From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106829 invoked by alias); 18 Feb 2020 13:13:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106758 invoked by uid 89); 18 Feb 2020 13:13:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-24.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,LIKELY_SPAM_BODY,SPF_PASS autolearn=ham version=3.3.1 spammy=testcases=c2, chase?= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 13:13:18 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3F25BBBD1; Tue, 18 Feb 2020 13:13:16 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Be quiet about untested dtrace-prob.exp To: Luis Machado , gdb-patches@sourceware.org References: <20200218120235.GA9051@delia> From: Tom de Vries Message-ID: <511ae4d0-9d0b-fc77-5ad8-b99f6b0128f6@suse.de> Date: Tue, 18 Feb 2020 13:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00725.txt.bz2 On 18-02-2020 13:35, Luis Machado wrote: > On 2/18/20 9:02 AM, Tom de Vries wrote: >> Hi, >> >> When running gdb.base/dtrace-probe.exp, I get this on stdout/stderr: >> ... >> Running src/gdb/testsuite/gdb.base/dtrace-probe.exp ... >> gdb compile failed, ld: error in \ >>    build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe.o\ >>    (.eh_frame); no .eh_frame_hdr table will be created >> ld: crt1.o: in function `_start': >> start.S:110: undefined reference to `main' >> ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ >>    (.SUNW_dof+0x88): undefined reference to `main' >> ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ >>    (.SUNW_dof+0xb8): undefined reference to `main' >> collect2: error: ld returned 1 exit status >> >>                  === gdb Summary === >> >> nr of untested testcases         1 > > Odd. I'm running this natively on aarch64 and i don't see the same. I > only get output in gdb.log. > I've looked a bit at the semantics of output_clone (in /usr/share/dejagnu/framework.exp), and the only way I could think of how that would happen for you is if the output somehow starts with a keyword like PASS/FAIL/WARNING/ERROR/etc. [ If you want to chase that difference it could be useful to post a gdb.log/gdb.sum/stdout_stderr.log. ] Anyway, the behaviour I'm seeing looks correct to me. >> ... >> >> There is no reason to be this verbose about the failure to compile. >> >> Fix this by using quiet as additional option to gdb_compile in >> dtrace_build_usdt_test_program.  Note that the error message still >> occurs in >> gdb.log. >> >> Tested on x86_64-linux. >> >> OK for trunk? >> >> Thanks, >> - Tom >> >> [gdb/testsuite] Be quiet about untested dtrace-prob.exp >> >> gdb/testsuite/ChangeLog: >> >> 2020-02-18  Tom de Vries  >> >>     * lib/dtrace.exp (dtrace_build_usdt_test_program): Use quiet as >>     gdb_compile option. >> >> --- >>   gdb/testsuite/lib/dtrace.exp | 6 ++++-- >>   1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/testsuite/lib/dtrace.exp b/gdb/testsuite/lib/dtrace.exp >> index 9aed481f32..8f861c9de4 100644 >> --- a/gdb/testsuite/lib/dtrace.exp >> +++ b/gdb/testsuite/lib/dtrace.exp >> @@ -52,7 +52,8 @@ proc dtrace_build_usdt_test_program {} { >>       } >>         # 2. Compile testprogram.c. >> -    set options [list debug additional_flags=-I[file dirname >> $out_header_file]] >> +    set options [list debug quiet \ >> +             additional_flags=-I[file dirname $out_header_file]] >>       if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}.o" >> object ${options}] != ""} { >>           return -1 >>       } >> @@ -65,7 +66,8 @@ proc dtrace_build_usdt_test_program {} { >>       } >>         # 4. Link everything together to get the test program. >> -    if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} >> executable {debug}] != ""} { >> +    if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} >> executable \ >> +         {debug quiet}] != ""} { >>           return -1 >>       } >>   } >> > Then again, it wouldn't hurt to prevent noisy output. So, this LGTM. Ack, thanks for the review. - Tom