From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24146 invoked by alias); 14 Feb 2013 18:31:32 -0000 Received: (qmail 24132 invoked by uid 22791); 14 Feb 2013 18:31:31 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 18:31:24 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1EIVN3U030904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Feb 2013 13:31:23 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1EIVM0J016941; Thu, 14 Feb 2013 13:31:22 -0500 Message-ID: <511D2D7A.70403@redhat.com> Date: Thu, 14 Feb 2013 18:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it. References: <20130214171404.2223.83713.stgit@brno.lan> <20130214171411.2223.32326.stgit@brno.lan> <87r4kiixbe.fsf@fleche.redhat.com> <511D2805.9050606@redhat.com> <87mwv6ix72.fsf@fleche.redhat.com> <511D2980.10703@redhat.com> <87ehgiiwjb.fsf@fleche.redhat.com> In-Reply-To: <87ehgiiwjb.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00370.txt.bz2 On 02/14/2013 06:24 PM, Tom Tromey wrote: > Pedro> Yeah... It'd be an easier sell if libiberty wasn't such a > Pedro> kitchen sink. I know that parts of libiberty would be problematic > Pedro> for the Windows CE (I know, it's rotten by now), not sure about > Pedro> other ports. > > I suppose my main concern here is that the gdb/gdbserver unification > project will end up needing to reimplement chunks of libiberty. > But that would be a bad result, since libiberty already exists. Understood and agreed. I just prefer to cross that bridge when we come to it. BTW, I think with ACX_CONFIGURE_DIR, the fact that libiberty is at the top level and gdbserver isn't is no longer a problem. That's what we use to configure the gnulib/ dir under gdbserver. > I don't really care so much about this particular function. > It is small, it doesn't really matter. The xstrndup name is better > (IMO), but unimportantly so. -- Pedro Alves