From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98499-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24938 invoked by alias); 14 Feb 2013 15:57:20 -0000
Received: (qmail 24926 invoked by uid 22791); 14 Feb 2013 15:57:19 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 15:57:11 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1EFv34G022914	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 14 Feb 2013 10:57:03 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1EFv0G5008270;	Thu, 14 Feb 2013 10:57:02 -0500
Message-ID: <511D094C.50705@redhat.com>
Date: Thu, 14 Feb 2013 15:57:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: "Abid, Hafiz" <hafiz_abid@mentor.com>
CC: eliz@gnu.org, Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org,        marc.khouzam@ericsson.com
Subject: Re: [Patch] Get trace file name when using 'target tfile'
References: <1360856970.2842.4@abidh-ubunto1104>
In-Reply-To: <1360856970.2842.4@abidh-ubunto1104>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00349.txt.bz2

On 02/14/2013 03:49 PM, Abid, Hafiz wrote:

> Thanks everybody for review. The updated patch is attached. The changes from the previous version are.
> 
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
> 
> How does it look?


Thanks.  The code bits looks good to me.

Eli should review the new NEWS bit.

>     * remote.c (remote_get_trace_status): Initialize "filename"
>     field with NULL instead    of 0.

                             ^^^^

Something weird with spaces here.

-- 
Pedro Alves