From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4474 invoked by alias); 14 Feb 2013 12:53:54 -0000 Received: (qmail 4465 invoked by uid 22791); 14 Feb 2013 12:53:53 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 12:53:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1ECredU009696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Feb 2013 07:53:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1ECrc98014875; Thu, 14 Feb 2013 07:53:39 -0500 Message-ID: <511CDE52.3050508@redhat.com> Date: Thu, 14 Feb 2013 12:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp References: <20130213203131.30816.4686.stgit@brno.lan> <87a9r8kk4r.fsf@fleche.redhat.com> In-Reply-To: <87a9r8kk4r.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00343.txt.bz2 On 02/13/2013 08:56 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This patch fixes it. The issue is that we're entering the VALUE_LVAL > Pedro> (x) == lval_memory branch by mistake for references. The fix is just > Pedro> to swap the tests so references are checked first, like value_addr > Pedro> also handles references first. > > Pedro> Comments? > > It looks reasonable to me. Thanks. Checked in (v2). -- Pedro Alves