From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98486-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 761 invoked by alias); 14 Feb 2013 03:17:33 -0000
Received: (qmail 751 invoked by uid 22791); 14 Feb 2013 03:17:30 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 03:17:23 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1U5pK4-00034G-TE from Yao_Qi@mentor.com ; Wed, 13 Feb 2013 19:17:20 -0800
Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 13 Feb 2013 19:17:20 -0800
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Wed, 13 Feb 2013 19:17:19 -0800
Message-ID: <511C56FE.7000503@codesourcery.com>
Date: Thu, 14 Feb 2013 03:17:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: "Abid, Hafiz" <hafiz_abid@mentor.com>
CC: <gdb-patches@sourceware.org>, <palves@redhat.com>,	<marc.khouzam@ericsson.com>
Subject: Re: [Patch] Get trace file name when using 'target tfile'
References: <1360766298.2842.0@abidh-ubunto1104>
In-Reply-To: <1360766298.2842.0@abidh-ubunto1104>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00336.txt.bz2

On 02/13/2013 10:38 PM, Abid, Hafiz wrote:
> -  /* This is true if the status is coming from a file rather
> -     than a live target.  */
> -  int from_file;
> +  /* If the status is coming from a file rather than a live target,
> +     this points at the file's filename.  Otherwise, this is NULL.  */
> +  const char *from_file;

How about rename this field to "trace_filename", or something similar? 
"from_file" is fine as a boolean, but is confusing as a the name of 
trace file.

-- 
Yao (齐尧)