From: Marcus Shawcroft <marcus.shawcroft@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] Fix %llx ARI gripe in aarch64-linux-nat.
Date: Wed, 13 Feb 2013 13:22:00 -0000 [thread overview]
Message-ID: <511B938C.9070404@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Hi,
This patch fixes the ARI gripe about the use of %llx in aarch64-linux-nat.
I'll commit this as obvious shortly.
/Marcus
2013-02-13 Marcus Shawcroft <marcus.shawcroft@arm.com>
* aarch64-linux-nat.c (debug_reg_change_callback)
(aarch64_linux_get_debug_reg_capacity): ARI fix: Replace %llx with
%s and phex().
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-AArch64-replace-ll-with-s-and-phex.patch --]
[-- Type: text/x-patch; name=0002-AArch64-replace-ll-with-s-and-phex.patch, Size: 2866 bytes --]
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 7cbd8b8..a2b6815 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -344,9 +344,10 @@ debug_reg_change_callback (struct lwp_info *lwp, void *ptr)
fprintf_unfiltered (gdb_stdlog,
"debug_reg_change_callback: \n\tOn entry:\n");
fprintf_unfiltered (gdb_stdlog,
- "\tpid%d, dr_changed_bp=0x%llx, "
- "dr_changed_wp=0x%llx\n",
- pid, info->dr_changed_bp, info->dr_changed_wp);
+ "\tpid%d, dr_changed_bp=0x%s, "
+ "dr_changed_wp=0x%s\n",
+ pid, phex (info->dr_changed_bp),
+ phex (info->dr_changed_wp));
}
dr_changed_ptr = is_watchpoint ? &info->dr_changed_wp
@@ -370,9 +371,10 @@ debug_reg_change_callback (struct lwp_info *lwp, void *ptr)
if (debug_hw_points)
{
fprintf_unfiltered (gdb_stdlog,
- "\tOn exit:\n\tpid%d, dr_changed_bp=0x%llx, "
- "dr_changed_wp=0x%llx\n",
- pid, info->dr_changed_bp, info->dr_changed_wp);
+ "\tOn exit:\n\tpid%d, dr_changed_bp=0x%s, "
+ "dr_changed_wp=0x%s\n",
+ pid, phex (info->dr_changed_bp),
+ phex (info->dr_changed_wp));
}
/* Continue the iteration. */
@@ -745,16 +747,16 @@ aarch64_linux_get_debug_reg_capacity (void)
aarch64_num_wp_regs = AARCH64_DEBUG_NUM_SLOTS (dreg_state.dbg_info);
if (aarch64_num_wp_regs > AARCH64_HWP_MAX_NUM)
{
- warning ("Unexpected number of hardware watchpoint registers reported"
- " by ptrace, got %d, expected %d.",
+ warning (_("Unexpected number of hardware watchpoint registers"
+ " reported by ptrace, got %d, expected %d."),
aarch64_num_wp_regs, AARCH64_HWP_MAX_NUM);
aarch64_num_wp_regs = AARCH64_HWP_MAX_NUM;
}
}
else
{
- warning ("Unable to determine the number of hardware watchpoints"
- " available.");
+ warning (_("Unable to determine the number of hardware watchpoints"
+ " available."));
aarch64_num_wp_regs = 0;
}
@@ -765,16 +767,16 @@ aarch64_linux_get_debug_reg_capacity (void)
aarch64_num_bp_regs = AARCH64_DEBUG_NUM_SLOTS (dreg_state.dbg_info);
if (aarch64_num_bp_regs > AARCH64_HBP_MAX_NUM)
{
- warning ("Unexpected number of hardware breakpoint registers reported"
- " by ptrace, got %d, expected %d.",
+ warning (_("Unexpected number of hardware breakpoint registers"
+ " reported by ptrace, got %d, expected %d."),
aarch64_num_bp_regs, AARCH64_HBP_MAX_NUM);
aarch64_num_bp_regs = AARCH64_HBP_MAX_NUM;
}
}
else
{
- warning ("Unable to determine the number of hardware breakpoints"
- " available.");
+ warning (_("Unable to determine the number of hardware breakpoints"
+ " available."));
aarch64_num_bp_regs = 0;
}
}
--
1.7.9.5
next reply other threads:[~2013-02-13 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 13:22 Marcus Shawcroft [this message]
2013-02-13 13:53 ` Pierre Muller
2013-02-13 14:36 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B938C.9070404@arm.com \
--to=marcus.shawcroft@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox