From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GZWJGRsOa2loMgcAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 23:20:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768623643; bh=Z7nb8ANZYQnKmFHpPAkSA7MTPd5deeT8rZ33UxXsEfg=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CqeyA/xNSxHOXUA6JFSovJay7Y+34DgGCK3ybmlwMK1V2un3WiKipSXCDbSiHEJL3 WXL/YmRid9x9066X/CuF8AILGpF+5chqfgEQoJ7WDsdi2WycbGU3n3NTpzajngInJe 3tZTKQe/xEwJHhI18CC9WC2A+JwiRyneY82CRkNQ= Received: by simark.ca (Postfix, from userid 112) id 639111E08D; Fri, 16 Jan 2026 23:20:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Wj15UlMA; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E756A1E08D for ; Fri, 16 Jan 2026 23:20:42 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 80D954BA2E2E for ; Sat, 17 Jan 2026 04:20:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80D954BA2E2E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Wj15UlMA Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B51E04BA2E26 for ; Sat, 17 Jan 2026 04:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B51E04BA2E26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B51E04BA2E26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768623604; cv=none; b=G75JVxvxmElrdzUHgQyO/674OW9Gxz972sKrGo0ors6TY/vX7mx3uJUHazOoih+hQLl/BjZBmjtBOMCtNXbTkzg69lzuMs42q65cJ+kMdRx2Qv6o2IyJ5TebgtzeSz+XXUreywOmteLC/EyfL7D8jH8B7s5bxX1UJ0I8BO1N8EM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768623604; c=relaxed/simple; bh=Z7nb8ANZYQnKmFHpPAkSA7MTPd5deeT8rZ33UxXsEfg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EJ2MaF0WHoZ5BXSdFb7rNOEnFF/Zy7zYsKxhemKtzPLlxPKiDS8ts4uR3yRyWKSNRQZh5SKwFYs5oOK+myZpKL70PgYYDl8YPTaXN6k7YQcoZiiXtazVk9DcfVvbPkApKdtaxzLtk2SuKij3ZO+B9dhlNztp/jc5TEWtBAC6G3c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B51E04BA2E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768623604; bh=Z7nb8ANZYQnKmFHpPAkSA7MTPd5deeT8rZ33UxXsEfg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Wj15UlMAR2mRIlUykfrx4E+B2MnRZFp0t9/fF9jP4Hi12SqE2zNQhWnZ/+Dq5kD15 G0xPYfn8yEpFVIEYVNFwlsxdBvaZTdizrCsogVfgA4B2l1W02T4OKHHFbqD5+Sn90/ y67hnKJgFsS0SsfUtTe7H0F+NF934gNJy6HENZ88= Received: by simark.ca (Postfix) id 3FC511E08D; Fri, 16 Jan 2026 23:20:04 -0500 (EST) Message-ID: <51167e14-61f2-4c58-9e8a-f89d3f09ba30@simark.ca> Date: Fri, 16 Jan 2026 23:20:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] More coffread cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-16 14:11, Tom Tromey wrote: > After Simon removed a huge chunk of coffread.c, I noticed there were > more cleanups that could be done. This series is the result. > > I'm not totally certain how to test this, but I did at least run the > resulting gdb on some Windows object files to make sure nothing > untoward happens. > > Signed-off-by: Tom Tromey This all looks fine to me, thanks. Approved-By: Simon Marchi Simon