From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9453 invoked by alias); 6 Feb 2013 20:31:41 -0000 Received: (qmail 9440 invoked by uid 22791); 6 Feb 2013 20:31:39 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 20:31:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r16KVSej028381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Feb 2013 15:31:29 -0500 Received: from localhost.localdomain (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r16KVR4n010342; Wed, 6 Feb 2013 15:31:27 -0500 Message-ID: <5112BD9E.10304@redhat.com> Date: Wed, 06 Feb 2013 20:31:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: Siva Chandra , gdb-patches@sourceware.org Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble References: <87y5f1w6xc.fsf@fleche.redhat.com> In-Reply-To: <87y5f1w6xc.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00163.txt.bz2 On 02/06/2013 07:58 PM, Tom Tromey wrote: >>>>>> "Siva" == Siva Chandra writes: > > Siva> +struct ui_out *py_out; > > I'd rather avoid new globals, and I don't see what this one adds. Perhaps it is global as ui_out structures are a finite resource? See ui-out.c: /* Maintain a stack so that the info applicable to the inner most list is always available. Stack/nested level 0 is reserved for the top-level result. */ enum { MAX_UI_OUT_LEVELS = 8 }; I think we already run into this with recursive inferior function calls in a python pretty printer: http://sourceware.org/bugzilla/show_bug.cgi?id=10344 But, caveats galore, I have no had time to truly look at the patch. Just a passing thought. Cheers, Phil