Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marcus Shawcroft <marcus.shawcroft@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] gdbserver switch ps_get_thread_area to PTRACE_GETREGSET
Date: Wed, 06 Feb 2013 17:38:00 -0000	[thread overview]
Message-ID: <51129511.7070601@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

This patch switches the aarch64 gdbserver ps_get_thread_area() 
implementation from PTRACE_GET_THREAD_AREA to PTRACE_GETREGSET.

OK?

/Marcus

2013-02-06  Marcus Shawcroft  <marcus.shawcroft@arm.com>

        * linux-aarch64-low.c (ps_get_thread_area): Replace
        PTRACE_GET_THREAD_AREA with PTRACE_GETREGSET.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-AArch64-GDBServer-switch-from-PTRACE_GET_THREAD_AREA.patch --]
[-- Type: text/x-patch;  name=0001-AArch64-GDBServer-switch-from-PTRACE_GET_THREAD_AREA.patch, Size: 1060 bytes --]

diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index 7f99887..e56ea80 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -1089,16 +1089,22 @@ aarch64_stopped_by_watchpoint (void)
 /* Fetch the thread-local storage pointer for libthread_db.  */
 
 ps_err_e
-ps_get_thread_area (const struct ps_prochandle * ph,
+ps_get_thread_area (const struct ps_prochandle *ph,
 		    lwpid_t lwpid, int idx, void **base)
 {
-  if (ptrace (PTRACE_GET_THREAD_AREA, lwpid, NULL, base) != 0)
+  struct iovec iovec;
+  CORE_ADDR reg;
+
+  iovec.iov_base = &reg;
+  iovec.iov_len = sizeof (reg);
+
+  if (ptrace (PTRACE_GETREGSET, lwpid, NT_ARM_TLS, &iovec) != 0)
     return PS_ERR;
 
   /* IDX is the bias from the thread pointer to the beginning of the
      thread descriptor.  It has to be subtracted due to implementation
      quirks in libthread_db.  */
-  *base = (void *) ((char *) *base - idx);
+  *base = (void *) (reg - idx);
 
   return PS_OK;
 }
-- 
1.7.9.5

             reply	other threads:[~2013-02-06 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 17:38 Marcus Shawcroft [this message]
2013-02-06 18:56 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51129511.7070601@arm.com \
    --to=marcus.shawcroft@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox