From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1820 invoked by alias); 5 Feb 2013 13:06:28 -0000 Received: (qmail 1809 invoked by uid 22791); 5 Feb 2013 13:06:27 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Feb 2013 13:06:14 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r15D6BOU001072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Feb 2013 08:06:11 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r15D6ABi003392; Tue, 5 Feb 2013 08:06:11 -0500 Message-ID: <511103C2.1020404@redhat.com> Date: Tue, 05 Feb 2013 13:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Marcus Shawcroft CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix layout in aarch64-tdep.c References: <511101D1.1000903@arm.com> In-Reply-To: <511101D1.1000903@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00117.txt.bz2 On 02/05/2013 12:57 PM, Marcus Shawcroft wrote: > This patch fixes the gripe: > > 0a1,2 >> gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end of a line > gdb/aarch64-tdep.c:776: pv_add_constant (regs[rn], imm)) || > > > OK? Of course. Thanks. -- Pedro Alves