From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98243-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12464 invoked by alias); 4 Feb 2013 19:04:25 -0000
Received: (qmail 12440 invoked by uid 22791); 4 Feb 2013 19:04:24 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 19:04:17 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 04 Feb 2013 19:04:15 +0000
Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 4 Feb 2013 19:04:14 +0000
Message-ID: <5110062D.8000201@arm.com>
Date: Mon, 04 Feb 2013 19:04:00 -0000
From: Marcus Shawcroft <marcus.shawcroft@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
MIME-Version: 1.0
To: Mark Kettenis <mark.kettenis@xs4all.nl>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  "palves@redhat.com" <palves@redhat.com>
Subject: Re: [PATCH] gdbserver ptrace() argument type cleanups.
References: <510FF048.8070701@arm.com> <201302041857.r14IvSWJ000937@glazunov.sibelius.xs4all.nl>
In-Reply-To: <201302041857.r14IvSWJ000937@glazunov.sibelius.xs4all.nl>
X-MC-Unique: 113020419041502901
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00093.txt.bz2

On 04/02/13 18:57, Mark Kettenis wrote:
>> Date: Mon, 04 Feb 2013 17:30:48 +0000
>> From: Marcus Shawcroft <marcus.shawcroft@arm.com>
>
>> -      ptrace (PTRACE_GETEVENTMSG, lwpid_of (event_child), 0, &new_pid);
>> +      ptrace (PTRACE_GETEVENTMSG, lwpid_of (event_child), (PTRACE_ARG3_=
TYPE) 0,
>> +	      &new_pid);
>
> I'd use the word "obfuscation" instead of "cleanup".
>

This change is ugly, agreed.  I'm open to better suggestions.

/Marcus