From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2436 invoked by alias); 4 Feb 2013 17:41:40 -0000 Received: (qmail 2382 invoked by uid 22791); 4 Feb 2013 17:41:39 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 17:41:32 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 04 Feb 2013 17:41:30 +0000 Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 4 Feb 2013 17:41:29 +0000 Message-ID: <510FF2C8.8010104@arm.com> Date: Mon, 04 Feb 2013 17:41:00 -0000 From: Marcus Shawcroft User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdbserver ptrace() argument type cleanups. References: <510FF048.8070701@arm.com> <510FF165.4090906@redhat.com> In-Reply-To: <510FF165.4090906@redhat.com> X-MC-Unique: 113020417413013501 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00083.txt.bz2 On 04/02/13 17:35, Pedro Alves wrote: > Hi Marcus, > > On 02/04/2013 05:30 PM, Marcus Shawcroft wrote: > >> This patch is ripped out of the aarch64 gdbserver patch here: >> >> http://sourceware.org/ml/gdb-patches/2013-01/msg00535.html >> >> These changes are not directly related to the aarch64 port itself. Since= ptrace() has a variadic prototype, the anonymous arguments, notably argume= nts 3 and 4, should be given their correct types. > > Excellent. Thanks for doing this. > >> gdb/gdbserver/ >> >> * linux-low.c (handle_extended_wait, linux_create_inferior) >> (linux_attach_lwp_1, linux_kill_one_lwp, linux_attach_one_lwp) >> (dequeue_one_deferred_signal, linux_resume_one_thread) >> (fetch_register, linux_write_memory, linux_enable_event_reporti= ng) >> (linux_tracefork_grandchild, linux_test_for_tracefork) >> (linux_read_offsets, linux_xfer_siginfo, linux_xfer_siginfo ): = Add > > Spurious space ------------------------------------------------------^ Ooops... I'll fix it up when I commit. Sorry /Marcus > >> PTRACE_ARG3_TYPE and PTRACE_ARG4_TYPE cast to ptrace arguments >> where the argument is 0. > > This is OK. > > Thanks! >