This is a re-spin of the AArch64 GDBserver patch: http://sourceware.org/ml/gdb-patches/2013-01/msg00535.html This version of the patch addresses the comments raised here: http://sourceware.org/ml/gdb-patches/2013-02/msg00010.html >> + /* Find the entry that matches the ADDR and CTRL. */ >> + for (i = 0; i < num_regs; ++i) >> + if (dr_addr_p[i] == addr && dr_ctrl_p[i] == ctrl) >> + { >> + gdb_assert (dr_ref_count[i] != 0); >> + break; > > "break" after gdb_assert is dead code. This one matters, it is required in order to terminate the loop early. All of the other comments have been addressed. The ptrace() changes have been split out to a separate patch, already posted. The remaining trivial changes to low-linux.c are irrelevant to the AArch64 port, so I have removed them. Cheers /Marcus Proposed ChangeLog 2013-02-04 Jim MacArthur Marcus Shawcroft Nigel Stephens Yufeng Zhang gdb/ * configure.tgt (aarch64*-*-linux*): Set build_gdbserver=yes. gdb/gdbserver/ * Makefile.in (clean): Remove aarch64.c and aarch64-without-fpu.c (aarch64.c, aarch64-without-fpu.c): New targets. * configure.srv (aarch64*-*-linux*): New. * linux-aarch64-low.c: New file.